Mailing-List: contact cygwin-apps-help AT sourceware DOT cygnus DOT com; run by ezmlm
Sender: cygwin-apps-owner AT sourceware DOT cygnus DOT com
List-Subscribe: <mailto:cygwin-apps-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-apps/>
List-Post: <mailto:cygwin-apps AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-apps-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/lists.html#faqs>
Delivered-To: mailing list cygwin-apps AT sources DOT redhat DOT com
From: "Ralf Habacker" <Ralf DOT Habacker AT freenet DOT de>
To: "Gerrit P. Haase" <cygwin-apps AT cygwin DOT com>
Cc: "Cygwin-Apps" <cygwin-apps AT cygwin DOT com>
Subject: RE: question about perl -i bug
Date: Thu, 29 Nov 2001 14:11:55 +0100
Message-ID: <009701c178d7$6b5e52d0$651c440a@BRAMSCHE>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3 (Normal)
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook 8.5, Build 4.71.2173.0
Importance: Normal
X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4133.2400
In-Reply-To: <185386229538.20011129085907@familiehaase.de>

Hi,
this patch fixes the "permission denied error for cygwin when inplace editing".
It provides an internal backup extension, if the -i option is set without a backup extension,
so this may be more a pracmatical workaround as a real bug fix, but it works and costs only 1
hour instead an "ideal" fix would cost about 5-8 hours. So this is very economical.  :-)

-------------------------------------------------------------------------------
ChangeLog
____________________________________________________________________________
[  ????] By: ????                                 on 2001/11/29  13:37:00
        Log: fixed permission denied error for cygwin when inplace editing
     Branch:
           ! perl.c

-------------------------------------------------------------------------------

$ diff -ubBp perl.c.org perl.c
--- perl.c.org  Wed Nov 28 09:34:24 2001
+++ perl.c      Thu Nov 29 12:35:36 2001
@@ -2135,6 +2135,12 @@ Perl_moreswitches(pTHX_ char *s)
     case 'i':
        if (PL_inplace)
            Safefree(PL_inplace);
+#if defined(__CYGWIN__)
+  if (*(s+1) == '\0') {
+      PL_inplace = savepv(".bak");
+      return s+1;
+       }
+#endif
        PL_inplace = savepv(s+1);
        /*SUPPRESS 530*/
        for (s = PL_inplace; *s && !isSPACE(*s); s++) ;

-----------------------------------------------------------------

> I use this kind of script to build bleadperl:
<snip>

Hmmh, I have done the foolowing like described in the INSTALL file and it works for 99%

        rm -f config.sh Policy.sh
        sh Configure -de
        make
        make test
        make install

The "make install" fails with an "install is up to date" error I don't know why
so I have choosed "make install-silent" or "install-verbose" and it goes.

After that I have tried preparing a kde package from cvs for configureing and it worked
(except another bug in make (.PHONY:cvs need in admin/Makefile.common ), but this will be
fixed next.

One question: Can anyone verify this patch ?

Second question: When this fix is okay, can someone tell me when an updated perl package will
be available on cygwin ?
I'm asking because we like to open the kde2 cvs archive in the next time and for that we need
an updated perl.

Regards Ralf