Mailing-List: contact cygwin-apps-help AT sourceware DOT cygnus DOT com; run by ezmlm
Sender: cygwin-apps-owner AT sourceware DOT cygnus DOT com
List-Subscribe: <mailto:cygwin-apps-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-apps/>
List-Post: <mailto:cygwin-apps AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-apps-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/lists.html#faqs>
Delivered-To: mailing list cygwin-apps AT sources DOT redhat DOT com
Message-ID: <3BF4B15E.3050005@ece.gatech.edu>
Date: Fri, 16 Nov 2001 01:25:35 -0500
From: Charles Wilson <cwilson AT ece DOT gatech DOT edu>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.4) Gecko/20011019 Netscape6/6.2
X-Accept-Language: en-us
MIME-Version: 1.0
To: Robert Collins <robert DOT collins AT itdomain DOT com DOT au>
CC: "Gerrit P. Haase" <cygwin-apps AT cygwin DOT com>
Subject: Re: indent is up now (third time)
References: <31871734698 DOT 20011116014516 AT familiehaase DOT de> <00ae01c16e61$12f9fa20$0200a8c0 AT lifelesswks>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit



Robert Collins wrote:

> 1) Perhaps I'm being to pedantic, but :'s in the setup.hint please.
> Also, it does work for C++, just not well :}.


Yep, you're being pedantic.  From the webpage:
"Note colons following keywords are optional in setup.hint file while they 
are mandatory in setup.ini."


> 2) you still have a patch that uses fmode. If you are linking against
> automode is that correct - or perhaps the patch is out of date?


Interject: IMO, binmode.o, textmode.o, and automode.o are all quick-n-dirty 
shortcuts.  The *real* solution is to do what you've done with squid: 
explicitly fix each and every open() and fopen() call, according to 
a_priori knowledge about the contents of each file (if possible).

e.g. .foorc is gonna be a text file.

However, this is hard, and takes a while to sort out all of the issues. 
E.g. automode = quick-n-dirty.

But, as long as the port *works* properly, the decision on how to address 
binmode/textmode issues is up to the maintainer.  E.g not me.


> 3) You've the same install-info issue that nano has (only install your
> files).
> 4) Like nano, you don't include enough information to reproduce the
> binary archive. Whilst I wouldn't put it as strongly as Chuck, this is
> reasonably important. (But not a showstopper for a straight forward
> package like indent :}).


Correct.  NOT a showstopper.

--Chuck