Mailing-List: contact cygwin-apps-help AT sourceware DOT cygnus DOT com; run by ezmlm
Sender: cygwin-apps-owner AT sourceware DOT cygnus DOT com
List-Subscribe: <mailto:cygwin-apps-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-apps/>
List-Post: <mailto:cygwin-apps AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-apps-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/lists.html#faqs>
Delivered-To: mailing list cygwin-apps AT sources DOT redhat DOT com
Subject: Re: whats left before releasing setup?
From: Robert Collins <robert DOT collins AT itdomain DOT com DOT au>
To: CA List <Cygwin-Apps AT Cygwin DOT Com>
In-Reply-To: <3BE7D865.8F33E90A@yahoo.com>
References: <1005048150 DOT 1442 DOT 0 DOT camel AT lifelesswks> 
	<3BE7D865 DOT 8F33E90A AT yahoo DOT com>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
X-Mailer: Evolution/0.15 (Preview Release)
Date: 06 Nov 2001 23:46:54 +1100
Message-Id: <1005050815.1471.12.camel@lifelesswks>
Mime-Version: 1.0
X-OriginalArrivalTime: 06 Nov 2001 12:53:05.0787 (UTC) FILETIME=[FA57E4B0:01C166C1]

On Tue, 2001-11-06 at 23:32, Earnie Boyd wrote:
> Robert Collins wrote:
> 
> > The setup.ini should now be ok,
> > the source discussion, IMO can be done separately from releasing
> > setup.exe.
> 
> If a release includes your changes to the Download Only dialogue
> presenting the setup Cygwin root directory dialogue then I don't think
> it's ready.  This shouldn't happen.  The mail list will complain.  I'm
> only downloading the packages not setting up Cygwin.  I don't want the
> registry infected with Cygwin entries by setup.exe if I'm only
> downloading packages.

I'll happily accept a patch to not write the last-cache file for
download only installs. That combined with an alteration to cygpath I've
prepared to return NULL on failure should allow the cache read routine
to fail safely too. (with a check for NULL of course :]).

Rob

This is the patch for mount.cc.

Index: mount.cc
===================================================================
RCS file: /cvs/src/src/winsup/cinstall/mount.cc,v
retrieving revision 2.6
diff -u -p -r2.6 mount.cc
--- mount.cc	2001/10/31 13:15:05	2.6
+++ mount.cc	2001/11/06 12:44:19
@@ -444,8 +444,11 @@ cygpath (const char *s, ...)
       match = m;
     }
 
+  if (!match)
+      return NULL;
+
   char *native;
-  if (max_len == strlen (path))
+  if (max_len == (int) strlen (path))
     native = strdup (match->native);
   else
     native = concat (match->native, "/", path + max_len, NULL);