Mailing-List: contact cygwin-apps-help AT sourceware DOT cygnus DOT com; run by ezmlm
Sender: cygwin-apps-owner AT sourceware DOT cygnus DOT com
List-Subscribe: <mailto:cygwin-apps-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-apps/>
List-Post: <mailto:cygwin-apps AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-apps-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/lists.html#faqs>
Delivered-To: mailing list cygwin-apps AT sources DOT redhat DOT com
Subject: Re: patches to vendor source trees - discussion
From: Robert Collins <robert DOT collins AT itdomain DOT com DOT au>
To: cygwin-apps AT cygwin DOT com
In-Reply-To: <3BE40C86.590FC8F4@yahoo.com>
References: <1004752145 DOT 521 DOT 38 DOT camel AT lifelesswks>
	<20011102210311 DOT D31918 AT redhat DOT com> <1004753755 DOT 520 DOT 55 DOT camel AT lifelesswks>
	<20011102212558 DOT F31918 AT redhat DOT com> <1004755024 DOT 520 DOT 61 DOT camel AT lifelesswks>
	<20011102214324 DOT K31918 AT redhat DOT com>  <3BE40C86 DOT 590FC8F4 AT yahoo DOT com>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
X-Mailer: Evolution/0.15 (Preview Release)
Date: 04 Nov 2001 11:47:32 +1100
Message-Id: <1004834853.4708.52.camel@lifelesswks>
Mime-Version: 1.0
X-OriginalArrivalTime: 04 Nov 2001 00:51:50.0486 (UTC) FILETIME=[E36D7F60:01C164CA]

On Sun, 2001-11-04 at 02:25, Earnie Boyd wrote:
> Christopher Faylor wrote:
> > 
> > On Sat, Nov 03, 2001 at 01:37:03PM +1100, Robert Collins wrote:
> > >On Sat, 2001-11-03 at 13:25, Christopher Faylor wrote:
> > >> On Sat, Nov 03, 2001 at 01:15:54PM +1100, Robert Collins wrote:
> > >> >On Sat, 2001-11-03 at 13:03, Christopher Faylor wrote:
> > >> >>Couldn't the patch remove itself?
> > >> >
> > >> >Not if you create the patch via diff!
> > >>
> > >> Why?  The patch could patch itself into a zero length file and the file
> > >> could be removed via "patch -E".
> > >
> > >To make the patch a zero length file, the entire contents need to be
> > >listed with a - before each line right?
> > >
> > >so how long is a file that completely contains itself?
> > 
> > Yep.  You're right.  If the patch was constructed from diff and if there
> > was only one file, you couldn't have the patch delete itself.
> > 
> 
> How about a script?  Call it say pristine-src or something like that. 
> You would give it a package-version for the parameter.  Then the script
> would apply the patch and if successful remove the patch file.  You
> could even give it some options to allow for a backup of the current src
> directory first.

Sure. But this is all predicated on the patch being in the source dir.
(And someone needs to write the script).

Chuck, I haven't heard from you on this bar the initial comments - and
given the number of packages you maintain....

Also, please note: I'm not suggesting that anyone has to repackage
existing stuff... only that new packages, and new releases of existing
packages should follow the guidelines we establish. I think anything
else would be madness.

Rob