Mailing-List: contact cygwin-apps-help AT sourceware DOT cygnus DOT com; run by ezmlm
Sender: cygwin-apps-owner AT sourceware DOT cygnus DOT com
List-Subscribe: <mailto:cygwin-apps-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-apps/>
List-Post: <mailto:cygwin-apps AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-apps-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/lists.html#faqs>
Delivered-To: mailing list cygwin-apps AT sources DOT redhat DOT com
Subject: Re: patches to vendor source trees - discussion
From: Robert Collins <robert DOT collins AT itdomain DOT com DOT au>
To: cygwin-apps AT cygwin DOT com
In-Reply-To: <20011102210311.D31918@redhat.com>
References: <1004752145 DOT 521 DOT 38 DOT camel AT lifelesswks> 
	<20011102210311 DOT D31918 AT redhat DOT com>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
X-Mailer: Evolution/0.15 (Preview Release)
Date: 03 Nov 2001 13:15:54 +1100
Message-Id: <1004753755.520.55.camel@lifelesswks>
Mime-Version: 1.0
X-OriginalArrivalTime: 03 Nov 2001 02:20:13.0083 (UTC) FILETIME=[119BD6B0:01C1640E]

On Sat, 2001-11-03 at 13:03, Christopher Faylor wrote:

> Couldn't the patch remove itself?

Not if you create the patch via diff!

> I think that putting the patch outside of the source directory would be
> counter-intuitive.  I agree that there should be just one file, though.

Hmm, not necessarily. Of course, if there is an expectation...
 
> One problem, of course, is that patch can't reliably remove a file.  It
> can remove files that become empty but, AFAIK, it can't remove directories
> that are made obsolete by the patch.

So maybe we should provide unpatched directories, and a patch to make it
cygwin-ready?
 
> How does debian handle this?  Is it similar to the method that you
> outlined?

Funnily enough, when you download the source via apt you get 3 files and
a dir:

package-version.orig.tar.gz
package-version-suffix.diff.gz
package-version-suffix.dsc

package-version is the vendor source tree unaltered. (and has no suffix)
the diff.gz makes the vendor tree debian package creation tools ready
the .dsc file is a PGP signed control file that includes all the
metadata - maintainer, architecture, build-dependencies, source and diff
file crc's etc. (The signing is to guarantee the file crc's).

And there is a tool that will download those three files via apt-get ,
and then extract, patch and build a package for one, in one command.
Quite nice really.

Rob