Mailing-List: contact cygwin-apps-help AT sourceware DOT cygnus DOT com; run by ezmlm
Sender: cygwin-apps-owner AT sourceware DOT cygnus DOT com
List-Subscribe: <mailto:cygwin-apps-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-apps/>
List-Post: <mailto:cygwin-apps AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-apps-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/lists.html#faqs>
Delivered-To: mailing list cygwin-apps AT sources DOT redhat DOT com
Date: Fri, 2 Nov 2001 21:03:11 -0500
From: Christopher Faylor <cgf AT redhat DOT com>
To: cygwin-apps AT cygwin DOT com
Subject: Re: patches to vendor source trees - discussion
Message-ID: <20011102210311.D31918@redhat.com>
Reply-To: cygwin-apps AT cygwin DOT com
Mail-Followup-To: cygwin-apps AT cygwin DOT com
References: <1004752145 DOT 521 DOT 38 DOT camel AT lifelesswks>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1004752145.521.38.camel@lifelesswks>
User-Agent: Mutt/1.3.21i

On Sat, Nov 03, 2001 at 12:49:04PM +1100, Robert Collins wrote:
>Ok, as promised, here is a new thread.
>
>What I've written in setup.html is that for a given
>package-version-suffix source tree we supply that pre-patched in
>/usr/src/pacakge-version-suffix/ and also include
>/usr/src/package-version-suffix.patch which is a single patch that when
>applied to the source tree will back it out to pristine, unaltered
>vendor supplied state.
>
>The goal - of reverting to an unaltered vendor tree - implies that the
>patch _cannot_ be included in that tree. It also implies that the patch
>will include the cygwin specific readme and everything else that is
>eventually included in the binary distribution file.

Couldn't the patch remove itself?

I think that putting the patch outside of the source directory would be
counter-intuitive.  I agree that there should be just one file, though.

One problem, of course, is that patch can't reliably remove a file.  It
can remove files that become empty but, AFAIK, it can't remove directories
that are made obsolete by the patch.

So, unless we provide a "cygpatch" tool that loses patch for doing the
patching, we're not going to be able to revert the directory to its
pristine state anyway, are we?

Another way of doing things is to squirrel the patches away in a
/usr/src/cygwin/SOURCES directory, like a certain software provider does.
I can't say that I like that method much, though.

How does debian handle this?  Is it similar to the method that you
outlined?

cgf