Mailing-List: contact cygwin-apps-help AT sourceware DOT cygnus DOT com; run by ezmlm
Sender: cygwin-apps-owner AT sourceware DOT cygnus DOT com
List-Subscribe: <mailto:cygwin-apps-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-apps/>
List-Post: <mailto:cygwin-apps AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-apps-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/lists.html#faqs>
Delivered-To: mailing list cygwin-apps AT sources DOT redhat DOT com
Message-ID: <3B69E227.1030609@ece.gatech.edu>
Date: Thu, 02 Aug 2001 19:28:39 -0400
From: Charles Wilson <cwilson AT ece DOT gatech DOT edu>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.2) Gecko/20010713
X-Accept-Language: en-us
MIME-Version: 1.0
To: Charles Wilson <cwilson AT ece DOT gatech DOT edu>
CC: DJ Delorie <dj AT delorie DOT com>, binutils AT sources DOT redhat DOT com,
        cygwin-apps AT cygwin DOT com
Subject: Re: [RFA] pei386 dll: auto-import patch
References: <3B670087 DOT 7090102 AT ece DOT gatech DOT edu> <200108011735 DOT NAA32231 AT envy DOT delorie DOT com> <3B6846D2 DOT 9040206 AT ece DOT gatech DOT edu> <200108011847 DOT OAA32757 AT envy DOT delorie DOT com> <3B68C879 DOT 1070809 AT ece DOT gatech DOT edu> <200108020347 DOT XAA05289 AT envy DOT delorie DOT com> <3B68ED4B DOT 4080405 AT ece DOT gatech DOT edu> <200108020610 DOT CAA06564 AT envy DOT delorie DOT com> <3B68F80C DOT 7030207 AT ece DOT gatech DOT edu> <200108020700 DOT DAA06930 AT envy DOT delorie DOT com> <3B699A88 DOT 7060904 AT ece DOT gatech DOT edu> <200108021836 DOT OAA12734 AT envy DOT delorie DOT com> <3B69D143 DOT 5020100 AT ece DOT gatech DOT edu>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

(lots of stuff snipped):
Charles Wilson wrote:

> DJ Delorie wrote:
> 
>> +         /* If we haven't found very symbol, let's look for its
>> +            import thunk */
>>
>> Might want to check the text of this - found very symbol?
> 
> Corrected grammar.
> 
>> Otherwise, approved.  Please run a "make check" for gas/ld/binutils 
>> (cygwin+linux
>> preferred) before and after applying, to make sure it doesn't break
>> anything subtle.  Thanks!

 >

>> Also don't forget to change the dates in the ChangeLog ;-)
> 
> Done. Changelog split into two files: Changelog-bfd should go in 
> bfd/ChangeLog, Changelog-ld should go in ld/ChangeLog
> 
>>>   make data_import_dll static?
>>>     No, used in both pe.em and pe-dll.c
>>>     I suppose we could rename it pe_data_import_dll.
>>>
>>
>> If you wish to rename it, consider that approved as well.
> 
> data_import_dll renamed to pe_data_import_dll.


Committed patch with modifications described above.

--Chuck