Mailing-List: contact cygwin-apps-help AT sourceware DOT cygnus DOT com; run by ezmlm
Sender: cygwin-apps-owner AT sourceware DOT cygnus DOT com
List-Subscribe: <mailto:cygwin-apps-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-apps/>
List-Post: <mailto:cygwin-apps AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-apps-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/lists.html#faqs>
Delivered-To: mailing list cygwin-apps AT sources DOT redhat DOT com
Date: Thu, 2 Aug 2001 14:36:31 -0400
Message-Id: <200108021836.OAA12734@envy.delorie.com>
X-Authentication-Warning: envy.delorie.com: dj set sender to dj AT envy DOT delorie DOT com using -f
From: DJ Delorie <dj AT delorie DOT com>
To: cwilson AT ece DOT gatech DOT edu
CC: binutils AT sources DOT redhat DOT com, cygwin-apps AT cygwin DOT com
In-reply-to: <3B699A88.7060904@ece.gatech.edu> (message from Charles Wilson on
	Thu, 02 Aug 2001 14:23:04 -0400)
Subject: Re: [RFA] pei386 dll: auto-import patch
References: <3B670087 DOT 7090102 AT ece DOT gatech DOT edu> <200108011735 DOT NAA32231 AT envy DOT delorie DOT com> <3B6846D2 DOT 9040206 AT ece DOT gatech DOT edu> <200108011847 DOT OAA32757 AT envy DOT delorie DOT com> <3B68C879 DOT 1070809 AT ece DOT gatech DOT edu> <200108020347 DOT XAA05289 AT envy DOT delorie DOT com> <3B68ED4B DOT 4080405 AT ece DOT gatech DOT edu> <200108020610 DOT CAA06564 AT envy DOT delorie DOT com> <3B68F80C DOT 7030207 AT ece DOT gatech DOT edu> <200108020700 DOT DAA06930 AT envy DOT delorie DOT com> <3B699A88 DOT 7060904 AT ece DOT gatech DOT edu>


> Okay, new binaries and source tarball (plus the patch, ChangeLog, TODO 
> list, etc) are at:
> 
> http://www.neuro.gatech.edu/users/cwilson/cygutils/robert-collins/latest/binutils/

+         /* If we haven't found very symbol, let's look for its
+            import thunk */

Might want to check the text of this - found very symbol?

Otherwise, approved.  Please run a "make check" for gas/ld/binutils (cygwin+linux
preferred) before and after applying, to make sure it doesn't break
anything subtle.  Thanks!

Also don't forget to change the dates in the ChangeLog ;-)

> This version supersedes the one I posted late last night, and includes 
> all suggestions so far from DJ (including the non-float math above) and 
> has been (minimally) tested by me.  Open issues (other than more 
> thorough testing) are:
> 
>    make data_import_dll static?
>      No, used in both pe.em and pe-dll.c
>      I suppose we could rename it pe_data_import_dll.

If you wish to rename it, consider that approved as well.

>    Ralf's bug report.  My intuition sez this is
>      related to the data_import_dll thing.
>      http://sources.redhat.com/ml/binutils/2001-06/msg00742.html

This can be addressed separately after the current patch is committed,
but please do not forget about it once this patch is in!